Skip to content

fix filter sketch source #514

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Feb 14, 2020
Merged

fix filter sketch source #514

merged 5 commits into from
Feb 14, 2020

Conversation

umbynos
Copy link
Contributor

@umbynos umbynos commented Dec 12, 2019 •
edited
Loading

Hopefully this will fix this:

Go to Libraries
Search for 'up' . Find "UP SQUARED GROVE IOT DEV KIT"
Expand "Examples"
Choose Blink sample.
Choose board or port as " Intel X86_64 / IoT gateways
Click Verify.
Click "..." and "Export Cmake File"
Wait for zip to download, unzip the file. Open the Blink.ino.cpp.
The first two lines are random lines :
'
#line 1 "/tmp/115304058/Blink/Blink.ino"
#line 1 "/tmp/115304058/Blink/Blink.ino"
'
There is also
`
#line 26 "/tmp/115304058/Blink/Blink.ino"
void setup();
#line 34 "/tmp/115304058/Blink/Blink.ino"
void loop();
#line 26 "/tmp/115304058/Blink/Blink.ino"
'
Surprisingly, the same issue does not exist for other samples in the same library.

@claassistantio
Copy link

claassistantio commented Dec 12, 2019 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@umbynos umbynos marked this pull request as ready for review December 18, 2019 17:34
facchinm
facchinm requested changes Dec 18, 2019
View reviewed changes
Copy link
Member

@facchinm facchinm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure it is the file you really wanted to commit 🙂

@umbynos umbynos requested a review from facchinm December 20, 2019 09:24
umbynos
umbynos commented Dec 23, 2019
View reviewed changes
Copy link
Contributor Author

@umbynos umbynos left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should work now :)

@masci masci added this to the 0.8.0 milestone Dec 31, 2019
@rsora rsora requested a review from cmaglie January 17, 2020 12:09
cmaglie
cmaglie requested changes Jan 20, 2020
View reviewed changes
Copy link
Member

@cmaglie cmaglie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, I've misread the comment sorry for the noise...

@cmaglie cmaglie merged commit bc8e073 into arduino:master Feb 14, 2020
rsora pushed a commit that referenced this pull request Feb 14, 2020
@umbynos
Fix filter sketch source for "Export cmake" output (#514)
64c501d 
* fix filter sketch source

* removed lines generated from preprocessor

* remove file added by mistake

* remove lines generated by preprocessor in c_make file

* introduce again ContainerAddPrototypes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmaglie cmaglie cmaglie approved these changes

@facchinm facchinm facchinm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.8.0
Development

Successfully merging this pull request may close these issues.
5 participants
@umbynos @claassistantio @cmaglie @facchinm @masci